ROCKET_PORT isnt read from .env

[Weissnix4711]

Just a heads up for anyone else who runs into this issue (took me a solid while to figure out).

ROCKET_PORT (and possibly all the other rocket configuration, I haven't bothered checking) is not read from ENV_FILE. You must actually set it. If not, you get for example in a rootless container, this rather generic error:

~ $ ./start.sh 
/--------------------------------------------------------------------\
|                        Starting Vaultwarden                        |
|                           Version 1.35.4                           |
|--------------------------------------------------------------------|
| This is an *unofficial* Bitwarden implementation, DO NOT use the   |
| official channels to report bugs/features, regardless of client.   |
| Send usage/configuration questions or feature requests to:         |
|   https://github.com/dani-garcia/vaultwarden/discussions or        |
|   https://vaultwarden.discourse.group/                             |
| Report suspected bugs/issues in the software itself at:            |
|   https://github.com/dani-garcia/vaultwarden/issues/new            |
\--------------------------------------------------------------------/

[INFO] Using environment file `.env` for configuration.

Error: Rocket.
[CAUSE] Bind(
    Os {
        code: 13,
        kind: PermissionDenied,
        message: "Permission denied",
    },
)

[stefan0xC]

I use a .env for developing and I'm sure that the ROCKET_PORT and other environment variables are read from that file:

vaultwarden/src/config.rs

Lines 222 to 223 in 8f0e99b

	let env_file = get_env("ENV_FILE").unwrap_or_else(|| String::from(".env"));
	match dotenvy::from_path(&env_file) {

Existing environment variables will take precedence however so the issue you are running into is that the container image has already set those variables in the environment:

vaultwarden/docker/Dockerfile.debian

Lines 166 to 168 in 8f0e99b

	ENV ROCKET_PROFILE="release" \
	ROCKET_ADDRESS=0.0.0.0 \
	ROCKET_PORT=80 \

[Weissnix4711]

Ah, that would track, thanks.

Just my 2c but would it make sense to
a. just default to whatever unpriv port (iirc rocket uses 8000 or so by default?), to make running a rootless container just work out of the box, and/or
b. set these defaults in the binary instead, so they can be override by ENV_FILE. Skimming the code I see you already have checks like if is_running_in_container() && var("I_REALLY_WANT_VOLATILE_STORAGE").is_err() ..., I wonder if similar could be done in ConfigBuilder::build(), or
c. ship the container image with these defaults in /.env, this is the cleanest way I imagine. You can have different images with different defaults, and they can still be overridden by the user.

[stefan0xC]

I would prefer the first option but I think it is not possible without breaking the existing configurations of too many people but it's something to keep in mind if we ever do a major breaking change.

[BlackDex]

Indeed, and adding more different containera just for some env's is not really useful i think. It will only add more confusion and support burden.