fix(organizations): use GET for domain availability check#95
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the organizations.checkDomainIsAvailable() client method to match the Facturapi API contract by switching from an incorrect PUT with JSON body to a GET with query parameters, and adds a Node runtime compatibility test to lock in the expected request/response behavior.
Changes:
- Update
Organizations.checkDomainIsAvailable()to callGET /organizations/domain-checkusingparams(query string) instead of aPUTrequest body. - Add a Node runtime compatibility test asserting URL construction, HTTP method, Authorization header, and JSON response parsing for the domain check endpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/resources/organizations.ts |
Switch domain availability check to GET with query params via the wrapper client. |
test/node/runtime-compat.node.test.ts |
Add runtime test validating the GET /organizations/domain-check?domain=... request and parsed { available: true } response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raul-facturapi
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
organizations.checkDomainIsAvailable()to callGET /organizations/domain-checkwith query paramsPUT /organizations/domain-checkrequest body usageWhy
The Facturapi API defines domain availability as
GET /organizations/domain-check?domain=.... UsingPUTcan fail with 404/405 and does not match docs/spec.Testing
npm run test:node