Skip to content

Gsk 206 refactor demo projects#173

Merged
andreybavt merged 27 commits intomainfrom
GSK-206_refactor_demo_projects
Jul 29, 2022
Merged

Gsk 206 refactor demo projects#173
andreybavt merged 27 commits intomainfrom
GSK-206_refactor_demo_projects

Conversation

@princyiakov
Copy link
Copy Markdown
Contributor

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@princyiakov princyiakov requested a review from jmsquare July 25, 2022 13:29
@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Jul 25, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4041964 Generic High Entropy Secret d9720e2 giskard-demo-notebook/notebook/Email Classification Model.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@princyiakov princyiakov requested a review from andreybavt July 27, 2022 09:14
# Conflicts:
#	giskard-ml-worker/poetry.lock
#	giskard-ml-worker/pyproject.toml
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andreybavt andreybavt merged commit 18ea018 into main Jul 29, 2022
@Hartorn Hartorn deleted the GSK-206_refactor_demo_projects branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants