implement abstract methods for RagasEmbeddingsWrapper#2178
Merged
henchaves merged 2 commits intoGiskard-AI:mainfrom Jun 23, 2025
Merged
implement abstract methods for RagasEmbeddingsWrapper#2178henchaves merged 2 commits intoGiskard-AI:mainfrom
henchaves merged 2 commits intoGiskard-AI:mainfrom
Conversation
davidberenstein1957
approved these changes
Jun 23, 2025
Member
|
Hi @tituslhy, thanks for merging this PR last year. Giskard v3 is coming! So, we are closing some active issues and PRs related to v2 and shifting our focus to nailing v3. At the moment, we are still actively developing v3, so we are not looking for external contributions yet, but we would love to hear your early feedback and expectations on our roadmap and discussion: https://github.com/orgs/Giskard-AI/discussions/2250. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement abstract methods aembed_query and aembed_documents for
RagasEmbeddingsWrapper. These methods are required because theRagasEmbeddingsWrapperinherits from theBaseRagasEmbeddingsclass which has these abstract methods.Related Issue
This PR is related to issue number 2177.
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.pdm.lockrunningpdm update-lock(only applicable whenpyproject.tomlhas beenmodified)