chore: drop pkg_resources usage and setuptools dependency#2243
chore: drop pkg_resources usage and setuptools dependency#2243
Conversation
Summary of ChangesHello @henchaves, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's dependency management by eliminating the use of the deprecated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully removes the dependency on pkg_resources and setuptools from the project's runtime dependencies, which is a great modernization step. The fallback mechanism for version discovery has been updated to use importlib_metadata. I've included one suggestion to make the version retrieval logic more concise and Pythonic. The changes to pyproject.toml are appropriate, removing setuptools from the core dependencies while pinning it for tests, which is likely a necessary workaround for a dependency like mlflow.
| res = importlib_metadata.version(__name__) | ||
| if res is None: | ||
| # importlib_metadata can return None https://github.com/python/importlib_metadata/issues/371 | ||
| # fallback to pkg_resources even if it's deprecated | ||
| import pkg_resources | ||
|
|
||
| return pkg_resources.get_distribution(__name__).version | ||
| return importlib_metadata.distribution(__name__).version | ||
| return res |
There was a problem hiding this comment.
This block can be made more concise and Pythonic by using the or operator for the fallback. If importlib_metadata.version(__name__) returns None, the expression after or will be evaluated and returned.
| res = importlib_metadata.version(__name__) | |
| if res is None: | |
| # importlib_metadata can return None https://github.com/python/importlib_metadata/issues/371 | |
| # fallback to pkg_resources even if it's deprecated | |
| import pkg_resources | |
| return pkg_resources.get_distribution(__name__).version | |
| return importlib_metadata.distribution(__name__).version | |
| return res | |
| return importlib_metadata.version(__name__) or importlib_metadata.distribution(__name__).version |
|



Description
This PR replaces the usage of
pkg_resourcesin analytics, since it's not availanable anymore for setuptools>=81.Related Issue
Type of Change