-
-
Notifications
You must be signed in to change notification settings - Fork 424
feat(checks)!: [OSS-13] add RegexMatching check implementation #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattbit
merged 13 commits into
main
from
feature/ENG-1389-add-regex-support-to-stringmatching-check
Feb 26, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1370a71
feat(check): add RegexMatching check implementation
davidberenstein1957 39345aa
Apply suggestions from code review
davidberenstein1957 dd9358d
refactor: update Makefile commands and enhance RegexMatching document…
davidberenstein1957 5850095
fix: escape dollar sign in regex pattern for price validation
davidberenstein1957 d1def8f
Merge branch 'main' into feature/ENG-1389-add-regex-support-to-string…
davidberenstein1957 1973554
Merge branch 'main' into feature/ENG-1389-add-regex-support-to-string…
henchaves d131998
style: fix formatting issues
davidberenstein1957 7688edb
fix: remove regex flags and use inline modifiers instead
davidberenstein1957 5b3e3c3
refactor: rename string_matching module to text_matching and update i…
davidberenstein1957 b29da4f
Merge branch 'main' into feature/ENG-1389-add-regex-support-to-string…
henchaves 428dfe2
remove extra slash from line example
henchaves 67a18ef
small adjustments to RegexMatching docstring
henchaves 1a9760e
Merge branch 'main' into feature/ENG-1389-add-regex-support-to-string…
mattbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
232 changes: 0 additions & 232 deletions
232
libs/giskard-checks/src/giskard/checks/builtin/string_matching.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.