Conversation
Summary of ChangesHello @davidberenstein1957, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the LLM-based checks into a new judges module, which is a solid improvement for code organization and future maintainability. The changes correctly handle backward compatibility by re-exporting the moved classes. My review includes one suggestion to add a DeprecationWarning to guide users towards the new API and simplify future code cleanup.
- Added a new module for LLM-based judge checks, including `BaseLLMCheck`, `Conformity`, `Groundedness`, and `LLMJudge`. - Refactored existing checks to import judges from the new module for better organization and maintainability. - Implemented Jinja2 templating for dynamic rule evaluation in `Conformity` and context validation in `Groundedness`. - Created prompt templates for both `Conformity` and `Groundedness` checks to standardize evaluation criteria. - Enhanced the overall structure of the checks to support LLM evaluations more effectively.
e99761f to
bd9a10e
Compare
…d-prompt-reliant-checks
BaseLLMCheck,Conformity,Groundedness, andLLMJudge.Conformityand context validation inGroundedness.ConformityandGroundednesschecks to standardize evaluation criteria.Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.pdm.lockrunningpdm update-lock(only applicable whenpyproject.tomlhas beenmodified)