feat: reexport resolve at root level#2311
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the import path for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly re-exports the resolve function at the giskard.checks level, improving the library's public API. The changes are straightforward and achieve the intended goal. I've added a few minor suggestions to maintain alphabetical order in imports and __all__ lists, which will enhance code consistency and maintainability.
| TestCase, | ||
| TestCaseResult, | ||
| Trace, | ||
| resolve, |
| "TestCase", | ||
| "TestCaseResult", | ||
| "Trace", | ||
| "resolve", |
| "SuiteResult", | ||
| "TestCaseResult", | ||
| "TestCase", | ||
| "resolve", |
Reexports
resolveat the root level ofgiskard.checksas requested.Currently users have to do
from giskard.checks.core.extraction import resolve.This change allows
from giskard.checks import resolve.Fixes #2310