Skip to content

feat: reexport resolve at root level#2311

Merged
kevinmessiaen merged 1 commit intoGiskard-AI:mainfrom
Deepak8858:fix/issue-2310-reexport-resolve
Mar 19, 2026
Merged

feat: reexport resolve at root level#2311
kevinmessiaen merged 1 commit intoGiskard-AI:mainfrom
Deepak8858:fix/issue-2310-reexport-resolve

Conversation

@Deepak8858
Copy link
Copy Markdown
Contributor

Reexports resolve at the root level of giskard.checks as requested.

Currently users have to do from giskard.checks.core.extraction import resolve.
This change allows from giskard.checks import resolve.

Fixes #2310

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the import path for the resolve function, making it more accessible and convenient for users. By re-exporting resolve at a higher level in the package hierarchy, it simplifies the API and improves the developer experience without altering the function's underlying implementation or behavior.

Highlights

  • API Simplification: The resolve function, previously accessible via giskard.checks.core.extraction.resolve, is now re-exported at the root level of giskard.checks. This allows users to import it directly using from giskard.checks import resolve.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly re-exports the resolve function at the giskard.checks level, improving the library's public API. The changes are straightforward and achieve the intended goal. I've added a few minor suggestions to maintain alphabetical order in imports and __all__ lists, which will enhance code consistency and maintainability.

TestCase,
TestCaseResult,
Trace,
resolve,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better code readability and maintainability, it's a good practice to keep imports sorted alphabetically. resolve should be placed after Metric in this import list to maintain the alphabetical order.

"TestCase",
"TestCaseResult",
"Trace",
"resolve",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, please keep __all__ entries sorted alphabetically within their logical groups. resolve should be placed in alphabetical order within the 'Core classes' group.

"SuiteResult",
"TestCaseResult",
"TestCase",
"resolve",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's best to keep the __all__ list sorted alphabetically. This list is currently unsorted. Please place resolve in its correct alphabetical position. Sorting the entire list would be a great improvement for future changes.

@kevinmessiaen kevinmessiaen merged commit 651ef81 into Giskard-AI:main Mar 19, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Feature: reexport resolve at root level

3 participants