feat(checks): add print_report to result models#2314
Conversation
Introduce a shared BaseResult with a print_report helper and make result models immutable (frozen). Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the core result models by introducing a shared base class, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a BaseResult class to provide a shared print_report method for all result models (CheckResult, ScenarioResult, TestCaseResult, SuiteResult). It also makes these models immutable by setting frozen=True, which is a good practice for result objects. The changes are well-implemented and improve code reuse and consistency. I have one minor suggestion regarding code redundancy in the CheckResult class.
Introduce a shared BaseResult with a print_report helper and make result models immutable (frozen).
This automatically print pretty result for Suite, Scenario and Check results
Example:
Result:
Solve #2289