Conversation
- Add failures_and_errors on ScenarioResult and TestCaseResult - Refactor suite dots to use STATUS_MAPPING symbols - Render failures in Panels with FAILURES/SUMMARY sections and nested check output - Align CheckResult rich output with tab-separated details for non-pass states Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the clarity and detail of test suite reports, particularly when tests fail or encounter errors. By introducing new properties to aggregate failures and restructuring the console output with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the suite report by providing more detailed information about failures and errors. The addition of failures_and_errors properties on result objects is a good design choice. The new report structure with "FAILURES" and "SUMMARY" sections, using rich.Panel for details, greatly enhances readability. The refactoring to use symbols from STATUS_MAPPING for the dots view is a nice cleanup. I have one minor suggestion regarding the indentation in the summary section to improve consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| ) | ||
| yield "" | ||
|
|
||
| failures_and_errors = [r for r in self.results if r.failed or r.errored] |
There was a problem hiding this comment.
could move it outside the method, making possible to call suite_result.failures_and_errors
New report:
Old report: