fix(giskard-agents): use jinja2 sandboxed environment to prevent template injection [ENG-1486]

[mattbit]

Description

Use jinja2 sandboxed environment to prevent template injection if untrusted output is passed to the chat method.

Type of Change

• 📚 Examples / docs / tutorials / dependencies update
• 🔧 Bug fix (non-breaking change which fixes an issue)
• 🥂 Improvement (non-breaking change which improves an existing feature)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 🔐 Security fix

[linear]

ENG-1486 Security: Server-side template injection via ChatWorkflow.chat() using non-sandboxed Jinja2 Environment

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a security concern by upgrading the Jinja2 templating environment within the Giskard agents. The change ensures that all Jinja2 environments are sandboxed, significantly reducing the risk of template injection attacks when processing potentially untrusted inputs. This enhancement bolsters the overall security posture of the application without altering existing functionality.

Highlights

• Security Fix: Implemented the Jinja2 SandboxedEnvironment to prevent potential template injection vulnerabilities when untrusted output is passed to the chat method.
• Jinja2 Environment Update: Replaced standard Jinja2 Environment with SandboxedEnvironment for both the _inline_env and the environment created by create_message_environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Jinja2 environment usage from jinja2.Environment to jinja2.sandbox.SandboxedEnvironment in libs/giskard-agents/src/giskard/agents/templates/environment.py. This change likely enhances security by running templates in a sandboxed environment. I have no feedback to provide on the review comments as none were provided.