Conversation
Caching only the ghost cells won't work as RemoveGhostCells modifies the output. Only new arrays are modified using PedigreeIds
|
@jourdain Please review |
|
Note that I had to update the input for the mappers (in my script) on the second render, otherwise I was seeing a crash at the second render: https://gitlab.kitware.com/danlipsa/quickview_optimize/-/commit/b3cc77daf462693b27a25b7daf8bbd79891aba57 I see a similar crash in Quickview, and it seems we don't do that there - but maybe I don't follow the code.
|
|
Seems there is an additional issue going on. I still get the crash if I update only the "trim". If I update both the trim and projection I don't get the crash (in my script). |
This also has the problem that it does not check the point modification time
2bf8cc1 to
cf7558a
Compare
This is fixed. |
|
@jourdain Please review. This fixes all issues I've been able to find in quickview. |
This is fixed |
|
LGTM, should I merge? |
|
@jourdain Two more commits. First one didn't reproduced it, but I think it better than before. The second one - a DeepCopy that was bothering me so I debugged to see what was the cause. |
|
I think now it is ready to be merged. You want to take another quick look? |
No description provided.