Improves the network offering creation form

[Tonitzpp]

Description

Currently, when creating a new network offering through the CloudStack graphical interface it is not possible to specify the specifyipranges parameter. Furthermore, the default value of the egressdefaultpolicy field is DENY, while the API's default is ALLOW.

This PR made modifications to add the specifyipranges field to the form and change the default value of egressdefaultpolicy.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

In the CloudStack graphical interface, I opened the create new network offering form and checked the new specifyipranges parameter was only in the Isolated guest type and checked that the default value of egressdefaultpolicy is now Allow. After creating the new network offering, I created a new network and it was observed in the form that the fields to specify the IPs ranges were present.

[bernardodemarco]

@blueorangutan ui

[blueorangutan]

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.52%. Comparing base (9cc6c09) to head (42b4c49).
⚠️ Report is 56 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9cc6c09) and HEAD (42b4c49). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (9cc6c09)	HEAD (42b4c49)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12951       +/-   ##
=============================================
- Coverage     17.93%    3.52%   -14.41%     
=============================================
  Files          5939      464     -5475     
  Lines        533147    40065   -493082     
  Branches      65237     7534    -57703     
=============================================
- Hits          95601     1414    -94187     
+ Misses       426804    38463   -388341     
+ Partials      10742      188    -10554     

Flag	Coverage Δ
uitests	3.52% <ø> (-0.14%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12951 (QA-JID-904)

[Copilot]

Pull request overview

This PR enhances the CloudStack UI network offering creation flow by exposing the specifyipranges API parameter in the form (for isolated guest networks) and aligning the UI default for egressdefaultpolicy with the API default (ALLOW).

Changes:

• Added a specifyipranges switch to the “Add Network Offering” form for isolated guest type offerings.
• Updated the form’s default egressdefaultpolicy value from deny to allow.
• Ensured specifyipranges is passed in request params where applicable and removed for L2 offerings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DaanHoogland]

@Tonitzpp , this is currently targetted for main/23, but I think it may be applicable for 22 or even 20 as well. Care to check?

[Tonitzpp]

@DaanHoogland, I tested the changes in both 4.20 and 4.22 versions, and it works in both of them. I will re-target my PR to the 4.20 branch.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17426