perf(tui): optimized extractCursorPosition to scan lines in reverse order#1004
Merged
badlogic merged 1 commit intobadlogic:mainfrom Jan 28, 2026
Merged
perf(tui): optimized extractCursorPosition to scan lines in reverse order#1004badlogic merged 1 commit intobadlogic:mainfrom
badlogic merged 1 commit intobadlogic:mainfrom
Conversation
…rder - Optimized extractCursorPosition to scan lines in reverse order for improved performance.
Owner
|
Embarassing. Cheers! |
Owner
|
This should also early out when above the visible viewport. |
Owner
Contributor
Author
|
@badlogic shouldn't it be const viewportTop = Math.max(0, lines.length - height);
for (let row = lines.length - 1; row >= viewportTop; row--) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized extractCursorPosition to scan lines in reverse order for improved performance.
Turns out this is one of the slowest functions during a regular session.
Mostly because it scans from the head instead of the tail.