fix(tui): prevent duplicate URL display for autolinked emails#888
Merged
badlogic merged 1 commit intobadlogic:mainfrom Jan 21, 2026
Merged
fix(tui): prevent duplicate URL display for autolinked emails#888badlogic merged 1 commit intobadlogic:mainfrom
badlogic merged 1 commit intobadlogic:mainfrom
Conversation
Autolinked emails like user@example.com were rendered as 'user@example.com (mailto:user@example.com)' because the comparison token.text === token.href failed (text lacks mailto: prefix). Now strips mailto: prefix before comparing, so autolinked emails display without redundant URL in parentheses.
Owner
|
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autolinked emails in markdown (e.g.
user@example.com) were rendered with a redundant mailto suffix:This was caused by the comparison
token.text === token.hreffailing because marked's autolink adds amailto:prefix to the href.Now strips the
mailto:prefix before comparing, so autolinked emails render cleanly:Explicit markdown links with different text still show the URL:
[Email me](mailto:user@example.com)→Email me (mailto:user@example.com)Rendered examples:
Before:
After: