ENT-13836: Added --check to cfengine format#56
Merged
olehermanse merged 1 commit intocfengine:mainfrom Apr 10, 2026
Merged
Conversation
victormlg
force-pushed
the
check
branch
2 times, most recently
from
e798e83 to
51248ba
Compare
Signed-off-by: Victor Moene <victor.moene@northern.tech>
olehermanse
reviewed
Apr 10, 2026
| ret |= _format_dirname(name, line_length, check) | ||
| continue | ||
| return 0 | ||
| return ret |
Member
There was a problem hiding this comment.
@victormlg I think we still want to return 0 if there is no --check and we successfully reformatted the file(s).
olehermanse
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.