Skip to content

Remove last updated information and sorting from MRVA views#13821

Merged
charisk merged 1 commit intomainfrom
charisk/remove-last-updated
Jul 27, 2023
Merged

Remove last updated information and sorting from MRVA views#13821
charisk merged 1 commit intomainfrom
charisk/remove-last-updated

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jul 26, 2023

The last updated/commit information was removed from MRVA (see github/vscode-codeql#2637) so I'm updating the docs and images to show that.

I'm not sure what requirements there are for images - do I need to make them match the existing ones?

@charisk charisk requested a review from a team as a code owner July 26, 2023 14:34
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Will let the docs team confirm that the images are okay 👌🏽

@shati-patel shati-patel added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jul 26, 2023
Copy link
Copy Markdown
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for making these updates @charisk! ✨

The screenshot resolution is perfect 🙂 the one thing I might suggest for the future is taking slightly smaller screenshots, which you can do for bigger UI elements by resizing your window. We don't have any official guidance on screenshot sizing for the CodeQL microsite, but for reference, we aim for less than 1,000 pixels wide on the broader docs site. Definitely not blocking for these updates! 🚀

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Jul 27, 2023

Thank you @sabrowning1 for the review and for the useful and clear guidance! I'll go ahead and merge since it's a bit of a pain getting new screenshots but will take that into account for next time!

@charisk charisk merged commit 8438fb2 into main Jul 27, 2023
@charisk charisk deleted the charisk/remove-last-updated branch July 27, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants