Merged
Conversation
Collaborator
Author
|
Merge this when https://www.githubstatus.com/ returns to all clear. |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables repository pre-commit hook enforcement in the Copilot coding agent environment and documents how to handle hook failures.
Changes:
- Configure the Copilot setup workflow to enable repository hooks via
core.hooksPath. - Add Copilot-specific documentation describing the pre-commit hook behavior and remediation steps.
- Add workflow logging to show the configured hooks path during setup verification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/copilot-setup-steps.yml |
Enables .githooks via git config core.hooksPath during Copilot agent setup and prints the configured hooks path. |
.github/copilot-instructions.md |
Adds guidance about pre-commit hook behavior in the Copilot coding agent environment and how to fix Spotless failures. |
Collaborator
|
@edburns you may want to look at the copilot feedback here. |
edburns
force-pushed
the
edburns/re-enable-pre-commit-hooks
branch
from
72746f1 to
99d4567
Compare
modified: .github/copilot-instructions.md Apply @Copilot review recommendation. > This new section says the pre-commit hook is “automatically enabled” via `copilot-setup-steps.yml`, but earlier in the same document (and in CONTRIBUTING/README) the hook is described as something developers must manually enable with `git config core.hooksPath .githooks`. Please clarify the scope (e.g., auto-enabled only in the Copilot coding agent environment; local development still requires manual enablement) to avoid conflicting guidance, and consider linking explicitly to `.github/workflows/copilot-setup-steps.yml` for precision. Signed-off-by: Ed Burns <edburns@microsoft.com>
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have determined that a possible cause of the problems is a series of 500 errors on GitHub. Given that we reverted some commits in this session as a means to determine the cause of the problem, I would now like to un-revert those reversions and push those changes to upstream/edburns/re-enable-pre-commit-hooks.