Fix ast view and command registration#1113
Merged
aeisenberg merged 3 commits intomainfrom Feb 4, 2022
Merged
Conversation
Two small bugs: 1. The AST view command was viewing the wrong ast when the command was selected from the context menu. It was always selecting the active editor instead of the item selected in the file menu. 2. The `codeql.showLogs` command was not being registered properly. With this change, there is uniform error handling, telemetry, and disposal.
shati-patel
reviewed
Feb 4, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! 🙌🏽
Just a minor comment/question: I accidentally selected "View AST" on a folder, which then showed up in the AST view (but doesn't have anything useful) 😅 Should this throw the error Cannot view the AST. Please select a valid source file...?
Contributor
Author
|
Thanks for finding that bug. I hadn't even thought of trying to run on a directory. |
When a directory is selected or there are multiple selections, do not show the command.
aeisenberg
force-pushed
the
aeisenberg/small-fixes
branch
from
271d168 to
c046d3b
Compare
shati-patel
approved these changes
Feb 4, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
🎉 Thanks for fixing this! 💖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs:
selected from the context menu. It was always selecting the active
editor instead of the item selected in the file menu.
codeql.showLogscommand was not being registered properly.With this change, there is uniform error handling, telemetry,
and disposal.
Checklist
ready-for-doc-reviewlabel there.