Allow compare view to work with quick-eval#2422
Merged
aeisenberg merged 1 commit intomainfrom May 16, 2023
Merged
Conversation
The compare view typically works by matching the results sets of queries. It only allows the results sets of queries with identical names to be compared. Manually run queries use `#select` as the default result set. However, quick eval queries use a different, generated, name. Therefore, these two kinds of queries cannot be compared. This commit changes the heuristics so that if there are no identical;y named results sets, the first result set of each query that is prefixed with `#` is used (this is the default result set). It also makes a slightly nicer error message if there are no comparable results sets.
charisk
approved these changes
May 16, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
I don't have a huge amount of context on the area but the code changes look sensible to me.
Contributor
Author
|
Thanks for the review. This area is not tested very well, but it's also not used very much. I think these changes are low risk. |
Contributor
|
Oh sorry I only just remembered, should we include anything in the CHANGELOG? |
Contributor
Author
|
Right...yes. Forgot that. Thanks for reminding. I'll put something up. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compare view typically works by matching the results sets of queries. It only allows the results sets of queries with identical names to be compared.
Manually run queries use
#selectas the default result set. However, quick eval queries use a different, generated, name. Therefore, these two kinds of queries cannot be compared.This commit changes the heuristics so that if there are no identical;y named results sets, the first result set of each query that is prefixed with
#is used (this is the default result set).It also makes a slightly nicer error message if there are no comparable results sets.
Checklist
ready-for-doc-reviewlabel there.