Queries Panel: run local query from file tab#2544
Merged
norascheuch merged 1 commit intomainfrom Jun 26, 2023
Merged
Conversation
norascheuch
force-pushed
the
nora/queries-panel-file-tab
branch
from
a913ed0 to
d4e9d64
Compare
shati-patel
reviewed
Jun 23, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Cool! I have a question about the visibility of this command, but looks good otherwise.
(I'm never hugely confident in my reviews though, so I wouldn't mind a second opinion for reviewing/approving 😺)
robertbrignull
approved these changes
Jun 26, 2023
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Code changes LGTM
I have the same question as @shati-patel about whether we want to feature flag this or not. I agree it pretty independent and could be nice to release it now.
norascheuch
force-pushed
the
nora/queries-panel-file-tab
branch
from
d4e9d64 to
10d8bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a run icon to
.ql-files and runs local query.Checklist
ready-for-doc-reviewlabel there.