Don't download artifacts for repos with no results in MRVA#2736
Merged
Don't download artifacts for repos with no results in MRVA#2736
Conversation
robertbrignull
approved these changes
Aug 22, 2023
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
The changes to repoHasDownloadableArtifact LGTM, and I tested it and it seems to be working as expected.
I'm not sure how to validate the changes to the mock API responses, but I trust you they are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we know the number of results, we use that to decide whether we want download an artifact or not.
Please review this commit by commit, since the only significant change is the first commit.
Checklist
ready-for-doc-reviewlabel there.