Merged
Conversation
Contributor
Author
|
Ugh, it looks like the new node version is breaking things 🤦🏽 ( |
Contributor
Author
We're going to need to update the node version soon (since the bug will happen for anyone using the new version locally), but let's leave that for a separate PR. |
robertbrignull
approved these changes
Sep 11, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
We've found the cause of the "Location is not defined" bug and thankfully we can work around it. It only happens in the codeQL.mockGitHubApiServer feature is enabled, which is made for developer testing, and therefore we don't expect any external users to hit this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release to include the changes from #2786.
A few changed files:
main).I've updated the node version in all the workflows and package files.I've updated thereleasing.mdinstructions to include all the files that are affected by the node version.Checklist
N/A
ready-for-doc-reviewlabel there.