Alternate fix for import highlighting with instantiations#2859
Closed
Alternate fix for import highlighting with instantiations#2859
Conversation
3 tasks
ginsbach
suggested changes
Oct 6, 2023
Contributor
ginsbach
left a comment
ginsbach
left a comment
There was a problem hiding this comment.
Thanks a lot for looking into this! Apologies for taking a bit of time to get back to you. I have this one minor suggestion, aside from that it looks good to me.
ginsbach
force-pushed
the
ginsbach/TextMateInstantiationSyntax
branch
from
8f37b90 to
22a5661
Compare
ginsbach
force-pushed
the
ginsbach/TextMateInstantiationSyntax
branch
from
22a5661 to
47fa163
Compare
Contributor
Author
|
Closing since this was already merged into the real PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate fix for #2792. It updates the heuristic for finding the end of an import directive. The new heuristic matches a zero-width string that is preceded by a character that could end the import directive (identifier,
>) and is not followed by a character that would continue the import directive (,,.,<,::).