Minor tidy-up for local-databases tests#3058
Merged
shati-patel merged 4 commits intomainfrom Nov 10, 2023
Merged
Conversation
shati-patel
commented
Nov 6, 2023
| }); | ||
|
|
||
| describe("when codeQL.codespacesTemplate is not set", () => { | ||
| describe("when codeQL.codespacesTemplate is set to false or not defined", () => { |
Contributor
Author
There was a problem hiding this comment.
I've combined these, since isCodespacesTemplate can't return undefined. It would get converted to false anyway.
shati-patel
commented
Nov 6, 2023
extensions/ql-vscode/test/vscode-tests/minimal-workspace/local-queries/local-databases.test.ts
Outdated
Show resolved
Hide resolved
charisk
approved these changes
Nov 7, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
LGTM, thanks for tidying up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few bits of clean-up, noticed in #3047.
Checklist
N/A
ready-for-doc-reviewlabel there.