Skip to content

Change dataflow and taint-tracking snippets to match the module-based API#3091

Merged
robertbrignull merged 3 commits intogithub:mainfrom
MathiasVP:autocomplete-to-new-dataflow-and-taint-tracking
Nov 27, 2023
Merged

Change dataflow and taint-tracking snippets to match the module-based API#3091
robertbrignull merged 3 commits intogithub:mainfrom
MathiasVP:autocomplete-to-new-dataflow-and-taint-tracking

Conversation

@MathiasVP
Copy link
Copy Markdown
Contributor

@MathiasVP MathiasVP commented Nov 24, 2023

The snippets were expanding to the old class-based dataflow API which we don't want users to use anymore.

This PR updates those snippets to expand to the new module-based API:

Screenshot 2023-11-24 at 17 57 17 Screenshot 2023-11-24 at 17 57 34

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@MathiasVP MathiasVP requested a review from a team as a code owner November 24, 2023 17:58
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on whitespace in the snippet, but looks good to me either way.

@MathiasVP
Copy link
Copy Markdown
Contributor Author

@robertbrignull I believe I've addressed all your comments (thanks for them!). Do you mind re-approving? 🙏

Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do so it's explicit 👍🏼

Though it isn't technically needed for this repo. The earlier review is still valid and allows merging.

@MathiasVP
Copy link
Copy Markdown
Contributor Author

Sure, can do so it's explicit 👍🏼

Though it isn't technically needed for this repo. The earlier review is still valid and allows merging.

Oh, thank you! I missed what the page was actually telling me 😂

Screenshot 2023-11-27 at 11 52 47

Anyway, I'm not in any rush to get this merged, so feel free to merge it whenever it fits you and your team best.

@robertbrignull robertbrignull merged commit 3c98f94 into github:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants