Add SARIF result comparison to compare view#3113
Merged
Conversation
koesie10
force-pushed
the
koesie10/compare-sarif-view
branch
2 times, most recently
from
c759af1 to
49114cc
Compare
koesie10
force-pushed
the
koesie10/compare-interpreted
branch
from
fc9430d to
a44f9ac
Compare
This adds the `alerts` result set to the compare view if an interpreted result is available. This assumes that the user has opened the query in the results view before opening the compare view. It will not interpret the results if the interpreted results are not available.
This moves reading of the result sets to the `compareResults` method since raw result sets don't need to be read for interpreted results and the `findResultSetsToCompare` method is shared between the two types of results.
This wires up the comparison of SARIF results in the compare view. It uses the same diffing algorithm as the raw results, but it uses the SARIF results instead of the raw results.
koesie10
force-pushed
the
koesie10/compare-interpreted
branch
from
a44f9ac to
d4a4536
Compare
charisk
approved these changes
Dec 15, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
I can't say I'm very deeply following all the code changes as I'm not super familiar with the area but it all seems to make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds diffing of SARIF results to the compare view. It naively compares the
JSON.stringifyof the SARIF results and doesn't do anything smart about differing paths etc.It's easiest to review this commit-by-commit.
Checklist
ready-for-doc-reviewlabel there.