Add timeouts to downloading databases and the CLI#3373
Merged
Conversation
koesie10
force-pushed
the
koesie10/download-timeout
branch
from
f18a0de to
1a9c792
Compare
charisk
approved these changes
Feb 22, 2024
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Code changes LGTM.
Do we need to update the CHANGELOG/any docs? Is Product aware of the new setting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds timeouts to downloading CodeQL databases and the CLI. The default for both is 10 seconds, meaning that if no data is received for at least 10 seconds, the download is cancelled with a timeout error. There are configurable settings for both timeouts to allow users with poor internet connections to configure these with longer timeouts.
Closes #903
Closes #3204
Checklist
ready-for-doc-reviewlabel there.