Switch from node-fetch to native Node.js fetch#3750
Merged
Conversation
koesie10
force-pushed
the
koesie10/switch-to-native-fetch
branch
from
a07075b to
f184b21
Compare
robertbrignull
approved these changes
Oct 8, 2024
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I've given it some quick tests and I didn't get any download errors.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on
node-fetchand uses the native Node.js fetch that is included in Node.js 20. This fixes an issue where some requests would fail without an error.Unfortunately, there is 1 test for which I couldn't find a way to make it work, so I've skipped that test (
variant-analysis-submission-integration.test.ts).I've also manually tested these changes. There is a change in how we're handling timeout errors (since the
AbortErrordoesn't exist anymore), but I was able to confirm that we still show the "The download timed out." error when a download times out.