Pass computeDefaultStrings to query server when compiling queries#694
Conversation
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Nice. I suggest adding a query integration test.
| * Whether to ensure that elements that do not have a displayString | ||
| * get reported anyway. Useful for universal compilation options. | ||
| */ | ||
| computeDefaultStrings: boolean; |
There was a problem hiding this comment.
Future work: This makes me think we should have an internal integration test, which checks the external and internal copies of this protocol are in sync.
|
Worth adding a short changelog entry too, since it's actually user-visible. Something like "Query results without a string representation were previously not computed. They will now be computed and displayed with a default placeholder string." |
|
Test is added and and query tests are now running in CI. |
extensions/ql-vscode/CHANGELOG.md
Outdated
| ## [UNRELEASED] | ||
|
|
||
| - Fix bug when removing databases where sometimes the source folder would not be removed from the workspace or the database files would not be removed from the workspace storage location. [#692](https://github.com/github/vscode-codeql/pull/692) | ||
| - Always pass the `computeDefaultStrings` flag to query compilation commands. This will change the output of some queries. [#694](https://github.com/github/vscode-codeql/pull/694) |
There was a problem hiding this comment.
I think I put this into an earlier comment I can't find - I'd prefer to mention what the user-facing change here is, i.e. query results with no string representation were previously omitted, and will now be displayed with placeholder text.
There was a problem hiding this comment.
Sure. I didn't quite know how to say it. This sounds good.
aeisenberg
force-pushed
the
aeisenberg/computeDefaultStrings
branch
from
0f7074b to
4b4a12b
Compare
aeisenberg
force-pushed
the
aeisenberg/computeDefaultStrings
branch
from
4b4a12b to
ed5dc69
Compare
2 participants
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.