Save downloaded DB archives to disk before unzipping#700
Merged
alexet merged 2 commits intogithub:mainfrom Dec 14, 2020
Merged
Conversation
This fixes two classes of DBs that can't be installed directly from downloading: 1. DBs whose central directories do not align with their file headers. We need to download and save the entire archive before we can read the central directory and use that to guide the unzipping. 2. Large DBs require too much memory so can't be downloaded and unzipped in a single stream. We also add proper progress notifications to the download progress monitor so users are aware of how many more MBs are left to download. It's not yet possible to do the same for unzipping using the current unzipper library, since unzipping using the central directory does not expose a stream.
aeisenberg
force-pushed
the
aeisenberg/download-to-file
branch
from
9571223 to
747ff45
Compare
alexet
approved these changes
Dec 14, 2020
alexet
left a comment
alexet
left a comment
There was a problem hiding this comment.
LGTM. I tried to resolve the merge conflict in the ui but have realised it would have probably been cleaner for you to rebase instead. Feel free to remove my merge commit and rebase instead.
|
Actually squash and merge will do the right thing. |
Contributor
Author
|
Thanks for the review! |
aofaof0907
pushed a commit
to aofaof0907/vscode-codeql
that referenced
this pull request
Jul 27, 2021
This fixes two classes of DBs that can't be installed directly from downloading: 1. DBs whose central directories do not align with their file headers. We need to download and save the entire archive before we can read the central directory and use that to guide the unzipping. 2. Large DBs require too much memory so can't be downloaded and unzipped in a single stream. We also add proper progress notifications to the download progress monitor so users are aware of how many more MBs are left to download. It's not yet possible to do the same for unzipping using the current unzipper library, since unzipping using the central directory does not expose a stream. Co-authored-by: Alexander Eyers-Taylor <alexet@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two classes of DBs that can't be installed directly from
downloading:
We need to download and save the entire archive before we can read
the central directory and use that to guide the unzipping.
in a single stream.
We also add proper progress notifications to the download progress
monitor so users are aware of how many more MBs are left to download.
It's not yet possible to do the same for unzipping using the current
unzipper library, since unzipping using the central directory does not
expose a stream.
Fixes #621
Fixes #622
Integration tests are passing and added two more for progress monitoring.
Manually tested on the linux database from lgtm https://lgtm.com/projects/g/torvalds/linux/ci and it is working.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.