Ensure databases are re-registered when query server restarts#734
Merged
aeisenberg merged 2 commits intogithub:mainfrom Jan 29, 2021
Merged
Ensure databases are re-registered when query server restarts#734aeisenberg merged 2 commits intogithub:mainfrom
aeisenberg merged 2 commits intogithub:mainfrom
Conversation
aeisenberg
force-pushed
the
aeisenberg/qs-restart
branch
from
ef8f294 to
b8b30f5
Compare
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Appreciate the quick fix and the test! A few minor suggestions.
aeisenberg
force-pushed
the
aeisenberg/qs-restart
branch
5 times, most recently
from
a14a093 to
4d9f2a0
Compare
adityasharad
approved these changes
Jan 29, 2021
This commit fixes github#733. It does it by ensuring that the query server emits an event when it restarts the query server. The database manager listens for this even and properly re-registers its databases. A few caveats though: 1. Convert query restarts to using a command that includes progress. This will ensure that errors on restart are logged properly. 2. Because we want to log errors, we cannot use the vscode standard EventEmitters. They run in the next tick and therefore any errors will not be associated with this command execution. 3. Update the default cli version to run integration tests against to 2.4.2. 4. Add a new integration test that fails if databases are not re-registered.
aeisenberg
force-pushed
the
aeisenberg/qs-restart
branch
from
4d9f2a0 to
2ec2f15
Compare
Contributor
Author
|
The integration tests were failing because of a real bug. Fixed now. I'm glad we upgraded the tests to run on 2.4.2 |
adityasharad
approved these changes
Jan 29, 2021
Contributor
|
Looks good. Do you want a change note for the upgrade bugfix? |
Contributor
Author
Sure...why not... |
aeisenberg
force-pushed
the
aeisenberg/qs-restart
branch
from
8b20cd5 to
faeddeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes #733. It does it by ensuring that the query server
emits an event when it restarts the query server. The database manager
listens for this even and properly re-registers its databases.
A few caveats though:
This will ensure that errors on restart are logged properly.
EventEmitters. They run in the next tick and therefore any errors
will not be associated with this command execution.
2.4.2.
re-registered.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.