Fix running tests when ms-python is installed.#803
Merged
adityasharad merged 2 commits intogithub:mainfrom Mar 22, 2021
Merged
Conversation
adityasharad
approved these changes
Mar 22, 2021
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Looks sensible. I first thought we should reset the prototype, but that creates similar downstream effects for other extensions.
Contributor
|
Forgot - can you add a changelog entry? This PR's title and link should be enough. |
Author
|
If we change the prototype then it depends which extension gets there first. |
aofaof0907
pushed a commit
to aofaof0907/vscode-codeql
that referenced
this pull request
Jul 27, 2021
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #802 by manually implementing
startsWith. This is probably a slight performance hit but I don't think we can do much about it.This is the only place where we use the two argument version whcih is the one that becomes broken.