Reregister testproj databases around test runs#868
Merged
cklin merged 1 commit intogithub:mainfrom May 20, 2021
cklin:reregister-testproj
Merged
Reregister testproj databases around test runs#868cklin merged 1 commit intogithub:mainfrom cklin:reregister-testproj
cklin merged 1 commit intogithub:mainfrom
cklin:reregister-testproj
Conversation
aeisenberg
reviewed
May 18, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
I think this generally looks like the right approach. See my comments inline.
aeisenberg
reviewed
May 18, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
We can chat about my comment tomorrow if you like.
aeisenberg
reviewed
May 20, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
This is looking great. A few smaller comments.
extensions/ql-vscode/src/vscode-tests/minimal-workspace/databases.test.ts
Show resolved
Hide resolved
aeisenberg
approved these changes
May 20, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
I'll approve now, assuming you update the changelog message.
To deal with the problem of CodeQL tests modifying open testproj databases, this commit removes open databases from the extension prior to running tests, and tries to open those databases again after tests finish running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the extension to reregister testproj databases around test execution.
Closes: #768
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.