Fix error from "Open Query Results" button

[shati-patel]

Fixes #906.

The "Open Query Results" button in the query history view currently doesn't work. Error: Cannot read property 'result' of undefined (codeQLQueryHistory.itemClicked).

I experimented a bit with the handleItemClicked, and it looks like changing singleItem to finalSingleItem works as expected 🙂

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [n/a] @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

[adityasharad]

Good catch, this looks sensible! Maybe we should have a query for this kind of pattern (later).

[shati-patel]

Aside: There was another point raised in the bug report:

Though to be honest, I am not sure if the "Open Query Results" button adds any value in the first place, since you would most likely first have to select the entry from the history (by left clicking?), but by doing so you already opened the query results.

I agree that the button doesn't add any extra functionality, but I assume it was added for a reason 😄 I guess it makes the command more obvious/discoverable?

[adityasharad]

I assume it was added for a reason 😄 I guess it makes the command more obvious/discoverable?

Looking at git blame on that line I think it was added so that we could have UI icons in the query history box for some of the common commands.