Allow exporting of results for non-alert queries#929
Merged
edoardopirovano merged 3 commits intogithub:mainfrom Aug 23, 2021
Merged
Allow exporting of results for non-alert queries#929edoardopirovano merged 3 commits intogithub:mainfrom
edoardopirovano merged 3 commits intogithub:mainfrom
Conversation
edoardopirovano
force-pushed
the
export-csv
branch
from
43d298a to
53a8cf7
Compare
edoardopirovano
force-pushed
the
export-csv
branch
from
53a8cf7 to
8c1e8a4
Compare
Contributor
Author
|
Rebased to fix a conflict in the CHANGELOG. |
shati-patel
reviewed
Aug 19, 2021
aeisenberg
reviewed
Aug 19, 2021
Contributor
Author
|
Thanks for the helpful comments @aeisenberg and @shati-patel! I've pushed an additional commit addressing them. |
edoardopirovano
force-pushed
the
export-csv
branch
from
4476955 to
d01278d
Compare
shati-patel
reviewed
Aug 19, 2021
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
aeisenberg
reviewed
Aug 19, 2021
|
|
||
| async exportCsvResults(qs: qsClient.QueryServerClient, csvPath: string, onFinish: () => void): Promise<void> { | ||
| let stopDecoding = false; | ||
| const out = fs.createWriteStream(csvPath); |
Contributor
There was a problem hiding this comment.
If the csv file already exists, then maybe no need to recreate it? Though if the operation is fast, not a big deal either way.
Contributor
Author
There was a problem hiding this comment.
This function is already not being called if the file already exists (see this line)
shati-patel
approved these changes
Aug 23, 2021
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks like all comments are addressed :)
|
Super excited to see this in the next release, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #832
This PR adds a new right click option in the Query History view called Export Results (CSV) which will export the results of a non-alert query to a CSV file (as chosen in a save dialog displayed to the user).
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.