Stick result pagination to top#936
Merged
aeisenberg merged 2 commits intogithub:mainfrom Aug 26, 2021
Merged
Conversation
Author
|
Not sure if any of the checklist items is relevant for such a change |
edoardopirovano
approved these changes
Aug 26, 2021
Contributor
edoardopirovano
left a comment
edoardopirovano
left a comment
There was a problem hiding this comment.
Nice! I would say this probably warrants a CHANGELOG entry as it is visible to users.
Author
|
Done |
Contributor
|
Nice! Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating pages of results, one had to scroll to top to go to the next page. Making the pagination controls stick to the top of the results editor, they're always at arms reach.
Fixes #526
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.