Add progress messages to LGTM download option.#960
Merged
shati-patel merged 6 commits intogithub:mainfrom Oct 4, 2021
Merged
Conversation
aeisenberg
reviewed
Oct 1, 2021
extensions/ql-vscode/CHANGELOG.md
Outdated
|
|
||
| ## [UNRELEASED] | ||
|
|
||
| - Remove line about selecting a language from the dropdown when downloading database from LGTM. This makes the download progress visible when the popup is not expanded. [#894](https://github.com/github/vscode-codeql/issues/894) |
Contributor
There was a problem hiding this comment.
Please remove this duplicated line.
extensions/ql-vscode/CHANGELOG.md
Outdated
|
|
||
| - Remove line about selecting a language from the dropdown when downloading database from LGTM. This makes the download progress visible when the popup is not expanded. [#894](https://github.com/github/vscode-codeql/issues/894) | ||
| - Add progress messages to LGTM download option. This makes the two-step process (selecting a project, then selecting a language) more clear. | ||
|
|
Contributor
There was a problem hiding this comment.
And there is an extra newline here.
| describe('databaseFetcher', function() { | ||
| describe('databaseFetcher', function () { | ||
| // These tests make API calls and may need extra time to complete. | ||
| const fakeProgress = (_: ProgressUpdate) => { /*do nothing*/ }; |
Contributor
There was a problem hiding this comment.
This could be converted into a test spy and you can later verify that this spy is invoked. This would ensure that the progress update is properly called.
eg-
let progressSpy: sinon.SinonStub<ProgressCallback>;
// and then in the before block:
progressSpy = sandbox.spy();
// and then in each test, after the call to convert databasea
expect(progressSpy).to.have.been.calledOnce;
shati-patel
approved these changes
Oct 4, 2021
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
This is great! Thanks for adding these progress messages 🎊
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
marcnjaramillo
added a commit
to marcnjaramillo/vscode-codeql
that referenced
this pull request
Oct 6, 2021
Add progress messages to LGTM download option. (github#960)
mgsium
pushed a commit
to mgsium/vscode-codeql
that referenced
this pull request
Oct 19, 2021
* Add progress messages to LGTM download option. * Add additional argument to get test passing again. * Make edits requested by @aeisenerg * Fix assertion in test case * Update extensions/ql-vscode/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested feature added: add progress messages to the LGTM download option.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.