Open
Conversation
Ports [test_string](https://github.com/nodejs/node/tree/main/test/js-native-api/test_string) from the Node.js test suite to the CTS. - Most of the files are identical except for the js files and CMakeLists.txt - js files use global assert and loadAddon instead of requiring modules - CMakeLists.txt sets NAPI_VERSION >= 10, as API like node_api_create_external_string_latin1 are available only from NAPI_VERSION >= 10. Ref [docs](https://nodejs.org/docs/latest/api/n-api.html#node-api-create-external-string-latin1) Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Contributor
Author
|
@legendecas Fixed the CI issue. Can we run the tests again? |
legendecas
reviewed
Apr 9, 2026
| // test_string addon requires Node-API version >= 10 | ||
| // (node_api_create_external_string_latin1/utf16). | ||
| // Node-API 10 is supported in Node.js >= 22.14.0 and >= 23.6.0. | ||
| if (Number(napiVersion) < 10) { |
Member
There was a problem hiding this comment.
Can we split the API tests requiring node_api_create_external_string_latin1/utf16 to a separate test, intead of skipping the whole test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
test_string from the Node.js test suite to the CTS.
docs