Skip to content

chore: apply eslint to ts files #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 1 commit into
base: main
Choose a base branch
from
+424 −22
Open

chore: apply eslint to ts files #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import { defineConfig, globalIgnores } from "eslint/config";
import globals from "globals";
import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';

export default defineConfig([
globalIgnores(["node"]),
globalIgnores(["**/CMakeFiles/**"]),
eslint.configs.recommended,
tseslint.configs.recommended,
{
files: ["tests/**/*.js"],
files: [
"tests/**/*.js",
],
languageOptions: {
// Only allow ECMAScript built-ins and CTS harness globals.
// This causes no-undef to flag any runtime-specific API (setTimeout, process, Buffer, etc.).
Expand All @@ -30,4 +36,16 @@ export default defineConfig([
],
},
},
{
files: [
"implementors/**/*.{js,ts}",
"scripts/**/*.{js,mjs}",
],
languageOptions: {
globals: {
...globals.es2025,
...globals.node,
},
},
},
]);
13 changes: 0 additions & 13 deletions implementors/node/run-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,6 @@ import { listDirectoryEntries, runFileInSubprocess } from "./tests.ts";
const ROOT_PATH = path.resolve(import.meta.dirname, "..", "..");
const TESTS_ROOT_PATH = path.join(ROOT_PATH, "tests");

const ASSERT_MODULE_PATH = path.join(
ROOT_PATH,
"implementors",
"node",
"assert.js"
);
const LOAD_ADDON_MODULE_PATH = path.join(
ROOT_PATH,
"implementors",
"node",
"load-addon.js"
);

async function populateSuite(
testContext: TestContext,
dir: string
Expand Down
Loading
Loading