meta: articles about PR communication

[vsemozhetbyt]

Recently, I've come across these articles:

1. A concise one, concerning more the PR author side:

https://slack.engineering/on-empathy-pull-requests-979e4257d158

2. An elaborate one, concerning more the PR reviewer side:

https://mtlynch.io/human-code-reviews-1/
https://mtlynch.io/human-code-reviews-2/

I wonder if it is worth to find a place for referencing them in the CONTRIBUTING.md and COLLABORATOR_GUIDE.md respectively (or in some other more appropriate doc).

P.S. A new one: https://css-tricks.com/code-review-etiquette/

[apapirovski]

I really like the second one. 👍 The first is a bit heavy handed about putting most of the responsibility on the person opening the PR. Maybe that's applicable to the culture at Slack but it certainly shouldn't be applicable to Node, especially given the number of first-time contributors.

[gibfahn]

I wonder if it is worth to find a place for referencing them in the CONTRIBUTING.md and COLLABORATOR_GUIDE.md respectively (or in some other more appropriate doc).

SGTM, sounds like a good PR.

[sreepurnajasti]

@vsemozhetbyt Both the articles are good to connect. Feels like CONTRIBUTING.md (Pull Request section) a good fit to hold this.

[vsemozhetbyt]

A new one: https://css-tricks.com/code-review-etiquette/

[vsemozhetbyt]

Part 2: https://mtlynch.io/human-code-reviews-2/

[mhdawson]

+1 to a reference in the collaborators guide.

[bnoordhuis]

COLLABORATOR_GUIDE.md is 10 or 15 pages long already. The longer you make it, the less people will read or remember it all.

[SalameWilliam]

I'll try to tackle this and include them in the CONTRIBUTING.md and/or the COLLABORATOR_GUIDE.md