-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
V8 gyp file refactor performance regression #23796
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.regressionIssues related to regressions.Issues related to regressions.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Description
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.regressionIssues related to regressions.Issues related to regressions.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Since #23182, we build V8 in Release mode with
-DENABLE_HANDLE_ZAPPING. This should only be enabled in debug mode.I’ve only noticed this because it’s started to show up as 2 % runtime overhead in benchmarks – I’m not familiar enough with GYP to address this myself.
@refack @nodejs/build-files