tools/test.py is not yet Python 3 compatible

[cclauss]

The other four Travis CI test runs now complete successfully on Python 3.6 but the Test C++ Suites run fails. HELP NEEDED: This blocks our progress on Python 3 compatibility and the root cause is hidden behind JavaScript code that I do not understand.

See #29451 to understand how the C++ tests fail on Travis CI. Any progress or hints would be much appreciated.

Note that https://github.com/nodejs/node/blob/master/tools/test.py#L32 does import imp which raises a deprecation warning and sometime soon we need to modify the related code to use import importlib (and possibly also import importlib.util) https://docs.python.org/3/library/importlib.html#module-importlib.util instead but I have tried a few times without success. I do not believe that this is the source of our inability to pass the Test C++ Suites.

As mentioned at:

1. build: ongoing list of actions for Python 3 compatibility #25789 (comment)
2. build: ongoing list of actions for Python 3 compatibility #25789 (comment)

• Version:
• Platform:
• Subsystem:

[cclauss]

@nodejs/python

[Trott]

@nodejs/testing

[sam-github]

@cclauss I'd like to help, but I don't know what C++ tests this refers to, or how to reproduce it.

make PYTHON=python3 test (which includes cctest) and the more explicit python3 tools/test.py -J --mode=release both pass on Linux, with python 3.7.3

Could you provide an example make or other CLI command that fails, so I can try running it?

Or, if its Travis specific, could you provide a link to a failing travis build, preferably with a PR branch that causes the failure (assuming some kind of Travis config change is required to cause the failure)?

[cclauss]

The other four Travis CI test runs now complete successfully on Python 3.6

This means that this issue is about Travis CI tests on Python 3.6.
It is also trying to point out there are five tests runs that are made on Travis CI.

but the Test C++ Suites run fails.

This means that the other four tests can safely be ignored for now because they already pass.
Test C++ Suites is in bold because it is the one test run that is failing and needs attention.

#29360 made these test failures evident but unfortunately it had to be reverted. Now #29451 clarifies how to test Python 3 on Travis CI.

Results from one week ago: https://travis-ci.com/nodejs/node/builds/125061793

[richardlau]

The Test C++ Suites run node-gyp to build the addons tests. Is node-gyp expected to be Python 3.6 compatible?

[sam-github]

Thanks for #29451, I attempted to use it to reproduce this, but since compilation is blocked by #29340, I'm not able to, yet.

Are there other fixes I can cherry-pick into #29451 to get a compile, so that I can get to the "Test C++ Suites" stage?

[cclauss]

#29346