UTF8 chars in ICU full and Windows

[dothebart]

Hi,
compiling ICU-full for windows requires adding /utf-8 to the msvc compiler switches - as discussed here:
refack/GYP3#60

I don't know whether this is the case for icu-small that ships with nodejs. However, the setting can be added to standalone.gypi like this:

        'msvs_settings': {
          'VCCLCompilerTool': {
            'MinimalRebuild': 'false',
            'BufferSecurityCheck': 'true',
            'EnableFunctionLevelLinking': 'true',
            'RuntimeTypeInfo': 'false',
            'WarningLevel': '3',
            'WarnAsError': 'true',
            'Detect64BitPortabilityProblems': 'false',
            'conditions': [
              ['use_clcache_mode=="true"', {
                'DebugInformationFormat': '1',
              }, {
                'DebugInformationFormat': '3',
              }],
              [ 'msvs_multi_core_compile', {
                'AdditionalOptions': ['/MP', '/utf-8'], <------------------- here
              }],
              ['component=="shared_library"', {
                'ExceptionHandling': '1',  # /EHsc
              }, {
                'ExceptionHandling': '0',
              }],
            ],

Maybe you want to adjust this in your gyp files.

[addaleax]

@nodejs/platform-windows

[pd4d10]

Should have been fixed in #30492

[jasnell]

Believe this is fixed now