nodejs-13.7.0 fails with ld.gold linker

[drwulsen]

• 13.7.0:
• Linux:

linking fails with ld.gold (binutils-2.33.1) in this way:

/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: error: /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/src/large_pages/ld.implicit.script:10:10: syntax error, unexpected STRING
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: fatal error: unable to parse script file /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/src/large_pages/ld.implicit.script
collect2: error: ld returned 1 exit status
make: *** [cctest.target.mk:195: /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/out/Release/cctest] Error 1
make: *** Waiting for unfinished jobs....
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: error: /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/src/large_pages/ld.implicit.script:10:10: syntax error, unexpected STRING
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: fatal error: unable to parse script file /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/src/large_pages/ld.implicit.script
collect2: error: ld returned 1 exit status
make: *** [mkcodecache.target.mk:172: /var/tmp/portage/net-libs/nodejs-13.7.0-r1/work/node-v13.7.0/out/Release/mkcodecache] Error 1

switching to ld.bfd yields in a error-less compilation and installation on gentoo.
Forcing the ld.bfd linker was done by prepending LDFLAGS="${LDFLAGS} -Wl,-fuse-ld=bfd" to the emerge command.

Searching around I found this:
https://lists.gnu.org/archive/html/bug-binutils/2016-12/msg00035.html
https://bugzilla.redhat.com/show_bug.cgi?id=927573
https://sourceware.org/bugzilla/show_bug.cgi?id=15373
Which says that ld.gold does not support the Insert statement in linker scripts.

If you want me to test something, please feel free to do so.

[richardlau]

Similar to #31249.

[bnoordhuis]

It's not quite the same as #31249, although you'll get the same link errors when you remove the INSERT BEFORE line from the linker script. ^^

I don't have time to look into it today but we probably don't need the linker script if we switch to the __executable_start symbol provided by LLVM's and GNU ld's default linker script; run ld --verbose to view it.

Caveat emptor: they're not completely interchangeable because there are a number of sections in between. __executable_start is about 8 MB below __nodetext so some code tweaking is necessary.

[bnoordhuis]

@drwulsen Can you try #31547?

[drwulsen]

@drwulsen Can you try #31547?

Sorry for the (too) late reply; just tested and it compiled as I hoped for.
Thank you for the quick steps taken!