-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
Add --error-on-warn to vcbuild.bat #33158
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.stalewindowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.stalewindowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Is your feature request related to a problem? Please describe.
Add the
--error-on-warnflag that was introduced in #32685 to vcbuild.batDescribe the solution you'd like
When
--error-on-warnflag is specified any compiler warnings should fail the build.