OutgoingMessage doesn't always emit close

[ronag]

Following test fails:

  const msg = new OutgoingMessage();
  assert.strictEqual(msg.destroyed, false);
  msg.destroy();
  assert.strictEqual(msg.destroyed, true);
  let callbackCalled = false;
  msg.write('asd', common.mustCall((err) => {
    assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
    callbackCalled = true;
  }));
  msg.on('error', common.mustCall((err) => {
    assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
    assert.strictEqual(callbackCalled, true);
  }));
  msg.on('close', common.mustCall(() => {
    // Won't call
    msg.end();
  }));

[XadillaX]

I'll take a look then.

[XadillaX]

Hmmmm, https://github.com/nodejs/node/pull/33654/files is related to this issue?

[ronag]

Not reallly...

[ronag]

Giving this more thought it's not a relevant use case. A bit confusing but it's never actually used like this in core.