[v18.x] broken build with ./configure --shared

[bnoordhuis]

v18.16.0 from tarball:

$ ./configure --shared && make -j12
# <snip>
In file included from ../deps/base64/base64/lib/codec_choose.c:7:
../deps/base64/base64/lib/codecs.h:5:10: fatal error: config.h: No such file or directory
    5 | #include "config.h"
      |          ^~~~~~~~~~
compilation terminated.
In file included from ../deps/base64/base64/lib/lib.c:9:
../deps/base64/base64/lib/codecs.h:5:10: fatal error: config.h: No such file or directory
    5 | #include "config.h"
      |          ^~~~~~~~~~
compilation terminated.
In file included from ../deps/base64/base64/lib/arch/generic/codec.c:7:
../deps/base64/base64/lib/arch/generic/../../codecs.h:5:10: fatal error: config.h: No such file or directory
    5 | #include "config.h"
      |          ^~~~~~~~~~
compilation terminated.
In file included from ../deps/base64/base64/lib/arch/neon32/codec.c:7:
../deps/base64/base64/lib/arch/neon32/../../codecs.h:5:10: fatal error: config.h: No such file or directory
    5 | #include "config.h"
      |          ^~~~~~~~~~
compilation terminated.
In file included from ../deps/base64/base64/lib/arch/neon64/codec.c:7:
../deps/base64/base64/lib/arch/neon64/../../codecs.h:5:10: fatal error: config.h: No such file or directory
    5 | #include "config.h"
      |          ^~~~~~~~~~
compilation terminated.

cc @richardlau - #45589 looks to be responsible

[bnoordhuis]

I tried reverting commits 2b0ace3 and 978cfad but I still get the same build error so maybe #45589 isn't responsible after all - or perhaps it's unfortunate interaction between those commits and something else.

[bnoordhuis]

I wanted to check newer tarballs but... nodejs/nodejs.org#5302

[richardlau]

@bnoordhuis I've not been able to reproduce this with the v18.16.0 source tarball:

$ sha256sum node-v18.16.0.tar.gz
6a4f5c5d76e5c50cef673099e56f19bc3266ae363f56ca0ab77dd2f3c5088c6d  node-v18.16.0.tar.gz
$ tar xfz node-v18.16.0.tar.gz
$ cd node-v18.16.0/
$ ./configure --shared && make -j88
...
if [ ! -r node ] || [ ! -L node ]; then \
  ln -fs out/Release/node node; fi
$ ./node -v
v18.16.0
$ ldd ./out/Release/node
        linux-vdso.so.1 (0x00007fffcab06000)
        libnode.so.108 => /tmp/node-v18.16.0/./out/Release/libnode.so.108 (0x00007fbaa6177000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00007fbaa5f73000)
        libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fbaa5bde000)
        libm.so.6 => /lib64/libm.so.6 (0x00007fbaa585c000)
        libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fbaa5644000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fbaa5424000)
        libc.so.6 => /lib64/libc.so.6 (0x00007fbaa505f000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fbaaba35000)
$

Linux x64 (RHEL 8, gcc 8.5.0)

[bnoordhuis]

I haven't been able to reproduce after unpacking the tarball again and doing a clean build so... 🤷

[bnoordhuis]

I just had this happen again with the v20.2.0 tarball... and I figured it out: #48174

Mea culpa, Richard, you're completely blameless.