Skip to content

process: make getActive{Handles,Requests} official#18844

Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:actives
Closed

process: make getActive{Handles,Requests} official#18844
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:actives

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Feb 18, 2018

process._getActiveHandles() and process._getActiveRequests() have been around for a long time, and are utilized to a large enough degree that it makes sense to make them official
APIs.

If this PR is accepted, I'll submit a follow up that deprecates the underscore prefixed versions.

Fixes: #1128

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: a way to inspect what's in the event loop

10 participants