-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
Incorrect slot check: typo in __dictoffset__ #123935
Copy link
Copy link
Closed
Labels
3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytopic-dataclassestype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Metadata
Metadata
Assignees
Labels
3.12only security fixesonly security fixes3.13bugs and security fixesbugs and security fixesstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytopic-dataclassestype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Bug report
I made a typo that made it into the final code:
cpython/Lib/dataclasses.py
Lines 1211 to 1212 in 00ffdf2
It should had been
__dictoffset__not__dictrefoffset__.Fixing plan:
__dictoffset__, so it won't happen again :)Linked PRs
_get_slotsindataclasses.py#123941_get_slotsindataclasses.py(GH-123941) #123991_get_slotsindataclasses.py(GH-123941) #123992